ok, just got home and done some testing.
To answer some of the questions above..
Yes I use cpanel hosting. It is theoretically possible my IP could be blocked.
ftp software: Cyberduck and Fetch and command line.
I reconnected with my Mac Book Pro direct to the modem and it works, obviously dfferant Mac address.
I then reconnect back to the router and tried again, blocked..I then spoofed the Mac address of my one of the gig ports on my Mac Pro, bounced the router and Modem and I have access through the router again.
The way this is going I feel as though there are two possibilities now.
1. Some sort of restrictive port 21 blocking somewhere
2. My cpanel host has blocked my external IP address from accessing port 21
The second seems most plausible. but not sure how it can be that selective, I'll try to examine the ftp logs to see if its blocked. This seems odd but not beyond the realms of possibility. Whats odd is that web access works fine. so it must be ProFTPd blocking me unless its number 1 above.
I'll contact my provider now to see if my IP turns up in firewall the logs.
I have a working solution other than my adsl connection, but for now I want my old IP address back
Thanks for all the help, glad its not me missing something stupid on my own firewalls, routers etc
Will update if I find anything. If not then I'll migrate to the new IP shortly.