Cable Forum - PHP Help!

Cable Forum (https://www.cableforum.uk/board/index.php)

- General IT Discussion (https://www.cableforum.uk/board/forumdisplay.php?f=19)

- - PHP Help! (https://www.cableforum.uk/board/showthread.php?t=25632)

yeah sure, although I will have to credit you so PM me your details if you want. In the mean time if I crack it I'll post back here!

As promised, this is the code I use for an image upload script - it's highly cut down because I do a helluva lot more with mine such as working out pixel counts etc (demo here: http://www.richardm.co.uk/gallery/?c...on=Screenshots)
Also, I think this code is an older version than what I'm using now but it should work.

HTML, important bits are marked in bold:

Quote:

<form action="./addimage.php" method="post" enctype="multipart/form-data">
<p>Choose file:</p>
<input type="file" name="ImageUploadedFile" /><br />
<input type="hidden" name="MAX_FILE_SIZE" value="1000000" />

PHP Code:


		
			
// Variables

$ImageDestination = $_POST['ImageDestination'];

$ImageFiletype = $HTTP_POST_FILES['ImageUploadedFile']['type'];

$ImageFilesize = $HTTP_POST_FILES['ImageUploadedFile']['size'];

$ImageUploadedFile = $HTTP_POST_FILES['ImageUploadedFile']['tmp_name'];

$ImageFilename = $HTTP_POST_FILES['ImageUploadedFile']['name'];



// Test Image - nothing allowed apart from jpg, gif and png.

if ($ImageFiletype == 'image/jpeg')

{

$ImageFiletype = 'jpg';

}

elseif ($ImageFiletype == 'image/gif') {

$ImageFiletype = 'gif';

}

elseif ($ImageFiletype == 'image/png') {

$ImageFiletype = 'png';

}

else {

echo '<html><body><p>The file was not an image!</p></body></html>';

exit;

}



echo '<html><body>';



// File handler

if(!is_array ($HTTP_POST_FILES['ImageUploadedFile'])) {

echo '<p>A file was not uploaded...<br />';

}

$f =& $HTTP_POST_FILES['ImageUploadedFile']; // saves typing

$dest_dir = "../gallery/" . $ImageDestination;

$dest = $dest_dir . '/'  . $f['name'];

if (!is_uploaded_file ($f['tmp_name'])) {

echo 'Error: No file uploaded.<br />';

}

if (!file_exists ($dest_dir)) {

echo "Error: Destination directory $dest_dir does not exist!<br />";

}

if (!is_dir ($dest_dir)) {

echo "Error: Destination directory $dest_dir is not a directory!<br />";

}

if (file_exists ($dest)) {

echo "<html><body>Error: File $dest already exists! I will try to overwrite it...<br />";

}

// all clear, move the file to its permanent location

$r = move_uploaded_file ($f['tmp_name'], $dest);

if ($r == false)

{ // something went wrong

echo "Error: Could not copy file to $dest <br />";

}

else {

echo 'File uploaded OK...';

}

echo '</body></html>';

If you want to credit me just link to www.richardm.co.uk - cheers. :)

Ah thanks for the effort, seen lot of these types of script whilst searching the web, not quite what I want but could be adapted, I really want to know why mine doesn't work though and if anything can be done to fix it. I shall fiddle around with your version though and add my ID loop and see how it goes.

I have had a quick look and it looks like the file is not being written fast enough so by the time it gets to line 29 ($fsize = filesize($dst)) the file can not be found. I can only assume that the processing continues immediately after the line copy($src, $dst) and the OS hasn't written the file yet. That would explain why small files work and large files don't. I've never used the usleep() function before but I can guess that it will act as a pause so either increase this and see what happens.

If it is what I suspect then there are several ways around this:

1. put a loop in to check for the existance of the file before continuing, use the file_exists() function.
2. use the system() function to do the copying. It should then wait for OS to finish processing before it continues processing the script.
3. if all you are after is the file size then you should be able to do something like $fsize = $_FILES['upfile']['size'][$idx] to get the size of the current file.

You're all brilliant! $fsize = $_FILES['upfile']['size'][$idx] seems to have fixed it, don't know why I didn't spot it! So thanks to iron25, Richard M and others, greenies for you all!:):)
I was thinking along the same lines as you iron25 so we must've been right, strange that it happens at exactly 10k, on PHP4 and 5 and on different server setups.